Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSigner method does not have docs #234

Open
tmctl opened this issue Aug 8, 2024 · 0 comments · May be fixed by #284
Open

getSigner method does not have docs #234

tmctl opened this issue Aug 8, 2024 · 0 comments · May be fixed by #284
Labels
Good First Issue An issue that is approachable for someone new to the library Needs Help Issues looking for contribution

Comments

@tmctl
Copy link
Contributor

tmctl commented Aug 8, 2024

Is your feature request related to a problem? Please describe. A clear and concise
There is a method in the dAppConnector that gets a signer specific to an account id. It does not have docs, this ticket is to add tsdocs to the method.

hedera-wallet-connect/src/lib/dapp/index.ts

Line 173 in c59a9ad

public getSigner(accountId: AccountId): DAppSigner {

@tmctl tmctl added Needs Help Issues looking for contribution Good First Issue An issue that is approachable for someone new to the library labels Aug 8, 2024
@Deligrim Deligrim linked a pull request Sep 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that is approachable for someone new to the library Needs Help Issues looking for contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tsdocs to the getSigner method Deligrim/hedera-wallet-connect
1 participant
@tmctl