Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ETH TX FeeSchedules #16765

Open
4 tasks
Tracked by #16761
Nana-EC opened this issue Nov 25, 2024 · 2 comments · May be fixed by #17147
Open
4 tasks
Tracked by #16761

Validate ETH TX FeeSchedules #16765

Nana-EC opened this issue Nov 25, 2024 · 2 comments · May be fixed by #17147
Assignees
@bubo
Labels
P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.
Milestone
v0.58

Comments

@Nana-EC
Copy link
Contributor

Nana-EC commented Nov 25, 2024 •
edited
Loading

Problem

feeSchedule.json is a little unclear on values in HSCS, let's confirm

Solution

Validate ETH TX FeeSchedules line up with https://docs.hedera.com/hedera/networks/mainnet/fees
Specifically note

  • ContractCreate - create smallest contract possible
  • ContractCall - set a single byte value
  • ContractLocalCall - get a single byte value
  • EthereumTransaction - simple crypto value transfer

Alternatives

No response
@Nana-EC Nana-EC added this to the v0.58 milestone Nov 25, 2024
@Nana-EC Nana-EC mentioned this issue Nov 25, 2024
Open
@Nana-EC Nana-EC added the P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. label Nov 25, 2024
@Nana-EC Nana-EC moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Nov 25, 2024
@Nana-EC
Copy link
Contributor Author

Nana-EC commented Dec 3, 2024

For supporting tests see #16846 that we should add HSCS coverage for

@bubo
Copy link

bubo commented Dec 17, 2024

I'm picking up this task.

@stoyanov-st stoyanov-st moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Dec 17, 2024
@stoyanov-st stoyanov-st linked a pull request Dec 20, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bubo bubo

Labels
P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.
Projects
Smart Contract Sprint Board
Status: Tasks In Progress
Milestone
v0.58
Development

Successfully merging a pull request may close this issue.

test: Contract Potential Inaccurate fee estimation #16761 bubo/hedera-services
2 participants
@bubo @Nana-EC