Configurable max transaction size #17099
Assignees
Labels
Feature Enhancement
Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Comments
steven-sheehy
added
the
Feature Enhancement
2 tasks
steven-sheehy
pushed a commit
to hashgraph/hedera-mirror-node
that referenced
this issue
Dec 20, 2024
This PR fixes BytecodeUtilsTest which were failing when ran against modularized flag. Made BytecodeUtilsTest extend AbstractContractCallServiceTest and now gets initial setup which makes most of the test except for one pass. The one test that did not pass was -> testExtractRuntimeBytecodeEthCall. The reason was that the EthCall.binary was bigger than services max transaction size with a little bit. This issue will be fixed in hashgraph/hedera-services#17099 Workaround solution for the test is: Deleted EthCall methods - getTokenName and getTokenSymbol. We have the exacts same tests in ContractCallServiceERCTokenReadOnlyFunctionsTest so these 2 can be deleted. Deleting those decreased the binary and now it passes services max txn size check. Changes in this PR also fix a couple of tests using the EthCall contract in ContracCallServiceTest. This PR modifies ... in order to support ... BytecodeUtilsTest - extends AbstractContractCallServiceTest EthCall.sol - delete getTokenName and getTokenSymbol to decrease contract binary Signed-off-by: Kristiyan Selveliev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
As part of the integration of the hedera.app dependency in the mirror node, we noticed that the
maxSignedTxnSizeis currently not configurable so the max value is 6 KB. On contract create, if the size of the contract is greater than this value, we need to make 2 transactions - one for file upload and one for the contract create using the file ID. Making 2 transactions would slow the performance down on our side.Solution
If the
maxSignedTxnSizebecomes configurable, we can increase the value of the property on our side and make only 1 transaction for contract create without the need for file upload.Alternatives
No response
The text was updated successfully, but these errors were encountered: