Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Investigate and fix issues in TokenCreateTransaction tests #244

Closed
ivaylogarnev-limechain opened this issue Sep 17, 2024 · 4 comments
Closed
Assignees
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Milestone

Comments

@ivaylogarnev-limechain
Copy link
Contributor

ivaylogarnev-limechain commented Sep 17, 2024

Description

Found some issues in the origin/00231-tck-implement-json-rpc-method-for-tokencreatetransaction:

Test (#1) Creates a token with an auto renew account (specifically the 2nd expect call) is failing for two reasons. First, the MirrorNodeClient class is not correctly retrieving data in the getTokenData() method. Second, the data from both the Consensus and Mirror clients must be awaited.

Upon reviewing the MirrorNodeClient class, I noticed the API endpoints didn’t align with the Swagger documentation and verifyTokenCreationWithInitialSupply helper function within the tokenCreateTransaction file must be awaited.

Steps to reproduce

  1. Clone and run an C++ SDK server in branch 00757-tck-c++-implement-json-rpc-methods-for-tokencreatetransaction
  2. Clone the TCK
  3. Checkout branch origin/00231-tck-implement-json-rpc-method-for-tokencreatetransaction
  4. Run npm test test/token-service/test_tokenCreateTransaction.js

Hedera network

hedera-local-node and testnet

Version

latest

Operating system

MacOS

@ivaylogarnev-limechain ivaylogarnev-limechain changed the title E2E Investigate and fix issues in TokenCreateTransaction tests E2E: Investigate and fix issues in TokenCreateTransaction tests Sep 17, 2024
@rwalworth rwalworth added this to the Sprint 10 milestone Oct 4, 2024
@rwalworth rwalworth added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Oct 4, 2024
@rwalworth
Copy link
Contributor

This work involved with this issue is now a part of #252.

@rwalworth
Copy link
Contributor

@ivaylogarnev-limechain you fine closing this since #252 has been merged?

@ivaylogarnev-limechain
Copy link
Contributor Author

@ivaylogarnev-limechain you fine closing this since #252 has been merged?

Yep, let we close it :)

@ivaylogarnev-limechain
Copy link
Contributor Author

This was completed in pull request #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

No branches or pull requests

2 participants