Remove references to node type #236
Labels
enhancement
New feature or request
Good First Issue
Issues which are ideal for a first time or new project contributor.
hacktoberfest
Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
help wanted
Extra attention is needed
🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
The function
getNodeType()
insetup_Tests.js
andNODE_TYPE
in the.env
files are remnants of an old implementation that is no longer used. These can be removed.Proposed Solution:
Remove the
getNodeType()
function fromsetup_Tests.js
and theNODE_TYPE
variable in the.env.custom_node
and.env.testnet
environment variable files. To verify functionality, follow the directions in the README to run an SDK server, and hedera-local-node if you choose to test locally, then runnpm run test
to run all tests. All tests should pass and no errors should be observed.📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.
sign-off
information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional Information
If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.
The text was updated successfully, but these errors were encountered: