Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new nextExchangeRate property to receipt #2727

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ivaylonikolov7
Copy link
Contributor

Description:

  • Adds new property nextExchangeRate to TransactionReceipt
  • Populates the nextRate protobuf related properties in from/toBytes
  • fixes unit tests

Fixes #2696

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners December 17, 2024 23:38
@ivaylonikolov7 ivaylonikolov7 changed the title feat: add new JS property feat: add new nextExchangeRate property to receipt Dec 17, 2024
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, can you add one integration tests that checks if nextExchangeRate is not null from the receipt?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new property nextExchangeRate in the receipt
2 participants