Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional costs field in EthereumTransactionBody #255

Conversation

dimitar-dinev
Copy link
Contributor

@dimitar-dinev dimitar-dinev commented Jan 24, 2023

Description:

Adds a max_additional_costs_allowance field to EthereumTransactionBody.

Related issue(s):

Fixes #254

@dimitar-dinev dimitar-dinev marked this pull request as ready for review January 24, 2023 14:23
@dimitar-dinev dimitar-dinev requested review from a team as code owners January 24, 2023 14:23
services/ethereum_transaction.proto Outdated Show resolved Hide resolved
services/ethereum_transaction.proto Outdated Show resolved Hide resolved
Signed-off-by: Dimitar Dinev <[email protected]>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as we may not need this any longer.

@dimitar-dinev
Copy link
Contributor Author

Closing this as a different fee-charging strategy involving multiple gas prices was chosen, and these changes are no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new field in EthereumTransactionBody for additional non-gas related costs
5 participants