Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: waffle tool example #2640

Merged
merged 4 commits into from
Jul 11, 2024
Merged

test: waffle tool example #2640

merged 4 commits into from
Jul 11, 2024

Conversation

arianejasuwienas
Copy link
Contributor

@arianejasuwienas arianejasuwienas commented Jul 1, 2024

Description:

Creates an example project demonstrating Waffle functionalities with Hedera Smart Contracts.

Adds a short Markdown file describing:

  • Key Waffle features
  • Their benefits and drawbacks for Hedera Smart Contract development
  • Recommended use cases and potential limitations

Related issue(s):

Implements #2641

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas arianejasuwienas mentioned this pull request Jul 1, 2024
2 tasks
@arianejasuwienas arianejasuwienas self-assigned this Jul 1, 2024
@arianejasuwienas arianejasuwienas added the enhancement New feature or request label Jul 1, 2024
@arianejasuwienas arianejasuwienas added this to the 0.52.0 milestone Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Tests

    2 files  158 suites   14s ⏱️
856 tests 855 ✔️ 1 💤 0
868 runs  867 ✔️ 1 💤 0

Results for commit 590fc66.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (265e137) to head (1d2eea5).
Report is 9 commits behind head on main.

Current head 1d2eea5 differs from pull request most recent head ce96bb5

Please upload reports for the commit ce96bb5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
- Coverage   77.06%   76.73%   -0.34%     
==========================================
  Files          40       40              
  Lines        3266     3301      +35     
  Branches      683      691       +8     
==========================================
+ Hits         2517     2533      +16     
- Misses        529      544      +15     
- Partials      220      224       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 1, 2024

Acceptance Tests

  16 files  202 suites   28m 42s ⏱️
577 tests 572 ✔️ 4 💤 1
613 runs  608 ✔️ 4 💤 1

Results for commit 590fc66.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

tools/waffle-example/.waffle.json Outdated Show resolved Hide resolved
tools/waffle-example/contracts/SampleContract.json Outdated Show resolved Hide resolved
tools/waffle-example/README.md Outdated Show resolved Hide resolved
tools/waffle-example/package.json Outdated Show resolved Hide resolved
tools/waffle-example/.waffle.json Outdated Show resolved Hide resolved
tools/waffle-example/test/rpc.js Outdated Show resolved Hide resolved
tools/waffle-example/package.json Outdated Show resolved Hide resolved
tools/waffle-example/README.md Outdated Show resolved Hide resolved
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Copy link

sonarcloud bot commented Jul 4, 2024

@arianejasuwienas
Copy link
Contributor Author

@acuarica Thank you! I’ve implemented your suggestions.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@se7enarianelabs se7enarianelabs merged commit 1aea661 into main Jul 11, 2024
32 of 33 checks passed
@se7enarianelabs se7enarianelabs deleted the waffle-tool-example branch July 11, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Waffle Usage Example for Hedera Smart Contract Development
5 participants