Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gradle tasks from different subproject are not isolated #337

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: gradle tasks from different subproject are not isolated #337

wants to merge 15 commits into from
+93 −100

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Nov 12, 2024

Description:

Isolate gradle tasks to not go outside of the respective project's build root.

Related issue(s):

Fixes #299

Notes for reviewer:

  • am I missing something?

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ata-nas ata-nas added Bug A error that causes the feature to behave differently than what was expected based on design docs Block Node Issues/PR related to the Block Node. labels Nov 12, 2024
@ata-nas ata-nas added this to the 0.3.0 milestone Nov 12, 2024
@ata-nas ata-nas self-assigned this Nov 12, 2024
@ata-nas ata-nas linked an issue Nov 12, 2024 that may be closed by this pull request
fix: gradle tasks from different subproject are not isolated #299
Open
@ata-nas ata-nas changed the title bug: gradle tasks from different subproject are not isolated fix: gradle tasks from different subproject are not isolated Nov 12, 2024
@ata-nas ata-nas marked this pull request as ready for review November 12, 2024 12:38
@ata-nas ata-nas requested review from a team as code owners November 12, 2024 12:38
@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from e3e75cc to 66d7417 Compare November 13, 2024 07:53
@ata-nas ata-nas requested a review from a team as a code owner November 13, 2024 12:12
@ata-nas ata-nas marked this pull request as draft November 13, 2024 12:25
@ata-nas ata-nas marked this pull request as ready for review November 13, 2024 14:39
mishomihov00
mishomihov00 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved only these files:
.github/workflows/e2e-tests.yaml
.github/workflows/smoke-test.yaml
server/docker/docker-build.sh
server/docker/docker-compose.yml
server/docker/update-env.sh

@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from 581174f to e94e061 Compare November 14, 2024 08:00
@ata-nas ata-nas mentioned this pull request Nov 14, 2024
Open
mishomihov00
mishomihov00 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved only these files:
.github/workflows/e2e-tests.yaml
.github/workflows/smoke-test.yaml
server/docker/docker-build.sh
server/docker/docker-compose.yml
server/docker/update-env.sh

georgi-l95
georgi-l95 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 👍 👉 👨‍💻

jeromy-cannon
jeromy-cannon previously approved these changes Nov 18, 2024
View reviewed changes
rbarkerSL
rbarkerSL requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

server/build.gradle.kts Outdated

tasks.register<Exec>("startDockerContainer") {
description = "Starts the docker container of the Block Node Server of the current version"
description =
"Starts the docker productiongit a container of the Block Node Server for the current version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Starts the docker productiongit a container of the Block Node Server for the current version"
"Starts the docker production container of the Block Node Server for the current version"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ @rbarkerSL thanks, I have missed that typo. This is pushed.

@ata-nas
isolating the updateDockerEnv task to build root
df80f69 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
providing the new .env file location
2f6447e 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
02650da 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
some javadoc
dc62963 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
.gitignore revert unintentional deletion
acd44ca 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
addressing pr comment
e7f74af 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
57c6cd5 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
generating .env is now responsibility of the respective start command
91bddcc 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
minor bugfix, removal of unused field and spotlessApply
44e3088 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
rename field to improve semantics
a125c20 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
some temporary fixes for the suites
203f75c 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
spotlessApply
d027c0b 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
stop the smoke test container from docker task
308bfa4 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas
tagging todos for the future
a8df065 
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas force-pushed the 299-bug-gradle-tasks-from-different-subproject-are-not-isolated branch from 4afe757 to a8df065 Compare November 18, 2024 15:56
@ata-nas
typo
0dc75b4 
Signed-off-by: Atanas Atanasov <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (256d486) to head (0dc75b4).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #337   +/-   ##
=========================================
  Coverage     94.05%   94.05%           
  Complexity      300      300           
=========================================
  Files            68       68           
  Lines          1177     1177           
  Branches         82       82           
=========================================
  Hits           1107     1107           
  Misses           57       57           
  Partials         13       13
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@jsync-swirlds jsync-swirlds Awaiting requested review from jsync-swirlds

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL

@mishomihov00 mishomihov00 Awaiting requested review from mishomihov00

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95

Requested changes must be addressed to merge this pull request.

Assignees

@ata-nas ata-nas

Labels
Block Node Issues/PR related to the Block Node. Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

fix: gradle tasks from different subproject are not isolated
6 participants
@ata-nas @jeromy-cannon @georgi-l95 @jsync-swirlds @rbarkerSL @mishomihov00