Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery to 3.x #177

Open
shreyas-satish opened this issue Oct 14, 2017 · 2 comments
Open

Update jQuery to 3.x #177

shreyas-satish opened this issue Oct 14, 2017 · 2 comments

Comments

@shreyas-satish
Copy link
Contributor

The admin interface is on 2.1.3 while the widget uses syntax (see $.get) which only works on versions >= 2.2. This inconsistency should be resolved by moving the whole app to the latest stable version of 3.x.

@shreyas-satish
Copy link
Contributor Author

It might a better idea for the ticketing widget to NOT use jQuery at all. The widget mostly only depends on jQuery for making cross-domain AJAX calls, while using ractive for the bulk of state management and DOM manipulation.

Pros:

  • Reduce the payload, and hence improve performance.
  • Remove the jQuery dependency for a site hosting the widget, and hence make for a simpler integration process.

Cons:

  • Time invested in looking for and testing a library that only does AJAX calls, or writing one ourselves. microjs lists some options.

@karthikb351
Copy link
Contributor

karthikb351 commented Oct 15, 2017

If only AJAX is needed, then just use the SuperAgent library inline? It's just 7kb and 369 LOC.

http://smalljs.org/ajax/superagent/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants