Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device timezone instead of account timezone #227

Open
jace opened this issue Jun 4, 2019 · 0 comments
Open

Use device timezone instead of account timezone #227

jace opened this issue Jun 4, 2019 · 0 comments
Assignees

Comments

@jace
Copy link
Member

jace commented Jun 4, 2019

Lastuser currently offers an account timezone that is propagated to client apps. Client apps will use the user account timezone if known, defaulting to app timezone, typically Asia/Kolkata.

This archaic approach has no place in a mobile first world where users expect the timezone on their device to be the only one that matters.

Baseframe should adopt Lastuser's timezone detecting library and use it all the time. The client-set cookie can have a one hour timeout so that it's periodically refreshed in case the user is travelling.

Lastuser should lose the account timezone column. There is no current use case for it and the potential for confusion exceeds currently known benefits.

Pending problem: what timezone is used for the first render without a user timezone cookie? Options:

  1. Auto-detect from the user's IP address. This is not reliable.
  2. Render dates in UTC but annotate them using <time> tags for the client to correct in JS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants