Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Baseframe's third-party assets into a separate repo #165

Open
jace opened this issue Sep 26, 2017 · 2 comments
Open

Split Baseframe's third-party assets into a separate repo #165

jace opened this issue Sep 26, 2017 · 2 comments

Comments

@jace
Copy link
Member

jace commented Sep 26, 2017

Baseframe's third-party asset collection messes with the commit history and content of this repository: committers get credit for code that is not theirs, and the repo appears to be mostly JS and CSS when the original content is mostly Python.

Third-party assets should be split out into an independent repository named baseframe_assets, with baseframe retaining an import hook to make them available as baseframe.assets.

@karthikb351
Copy link
Contributor

karthikb351 commented Sep 26, 2017

Will you then use baseframe_assets as a git submodule inside baseframe?
That way you get a link between versions of baseframe and baseframe_assets and can safely update/rollback.

@jace
Copy link
Member Author

jace commented Oct 11, 2017

I'm leaning towards totally independent packages:

  1. Git submodules are confusing because they link to specific releases. Every update to the submodule will require an update to the parent repo.
  2. We don't want to package assets into a PyPI release. Anyone using the source release should be able to install the other package to get assets.
  3. Private assets such as commercially-licensed icons can now be in a private repo, imported into baseframe via an app-specified import hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants