no scrolling on live map preview

[OpenBusBot]

Contact Name: דורון זמיר
Contact Email: [email protected]
Description:
במסך 'מפה בזמן אמת' לא מופיעים פסי גלילה ולא ניתן לראות את המפה. מצרף צילום מסך
Environment: ווינדוס, דפדפן edge
Expected Behavior:
האתר המוצג גדול מגודל המסך, צפוי שיופיעו פסי גלילה שמאפשרים גלילת המסך מטה ותצוגה של כולו
Actual Behavior:
לא מופיעים פסי גלילה ולא ניתן לגלול מטה וגם כאשר לוחצים על 'מפה במצב מלא' משהו לא מסתדר בתצוגה
Reproducibility: כל פעם

[YuvalMasada]

The map located at the end of the page which really seems odd and not so comfortable to look at.
@NoamGaash , it would be easier on the eye to add bottom margin and then it would be easy to see that the map is not overflowing on the Y-axis.
On cellphone the map ratio is better, but also looks like it overflow on the Y-axis.

tell me what you think

[NoamGaash]

@YuvalMasada I think a simple

.leaflet-container {
    min-height: calc(100vh - 88px);
}

will solve the issue

[YuvalMasada]

I've added the css you wrote in your comment. I'm adding a screenshot.

@NoamGaash do you think it needs some gap from the bottom of the page?
It might be something that only bothering me :D

[NoamGaash]

@YuvalMasada as you wish - you know better :)
I believe margin-bottom might help you here

[zushar]

fixing issue #721 can really fix it
@NoamGaash

[NoamGaash]

[YuvalMasada]

I've committed two css changes in https://github.com/hasadna/open-bus-map-search/pull/724

[NoamGaash]

solved in #724

Good Job @YuvalMasada ! 👏 🏅

[NoamGaash]

@all-contributors please add @YuvalMasada for code

[allcontributors]

@NoamGaash

I've put up a pull request to add @YuvalMasada! 🎉