Pcidevices vgpu support #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebberHuang1118
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
LGTM, just how about removing the trailing spaces? Thanks.
Verified with the following steps
- Deploying nvidia-driver-runtime
- Updating pci-controller manifest
- Enter pod harvester-cluster-repo-xxxx
- $ cd /srv/www/htdocs/charts/
- $ tar zxvf harvester-pcidevices-controller-0.2.5.tgz
- $ cd harvester-pcidevices-controller
- Edit
templates/daemonset.yamlas https://github.com/harvester/charts/pull/204/files#diff-41ca6c84283fa79c3f0ff7b48481047e88340d54e7ff08b913751fdb07c2a8d8 - Edit
templates/serviceaccount.yamlas https://github.com/harvester/charts/pull/204/files#diff-15629419a7389c01bf19faa71c3783cc1b3c025375f852539a3581a5ba6206dc - Edit
values.yamlas https://github.com/harvester/charts/pull/204/files#diff-79e6bb629bfedf31ca8995f839c3c0e27333d3926ccf78598e256fb0bc9b83d3 - $ helm dependency update
- $ rm harvester-pcidevices-controller-0.2.5.tgz
- $ tar zcvf harvester-pcidevices-controller-0.2.5.tgz harvester-pcidevices-controller
- Enabling pci-controller addon
- Updating pci-controller daemonset as gmehta3/pcidevices:vgpu2
- Enabling SRIOVGPUDevice
- Enabling VGPUDevice
bk201
approved these changes
Jan 23, 2024
ibrokethecloud
added a commit
to ibrokethecloud/harvester-charts
that referenced
this pull request
Jan 23, 2024
* changes for vgpu support * updated rbac permissions * mount file command from host to pod for local executor * cleanup empty spaces
WebberHuang1118
pushed a commit
that referenced
this pull request
Jan 23, 2024
* changes for vgpu support * updated rbac permissions * mount file command from host to pod for local executor * cleanup empty spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces changes needed in the pcidevices controller chart for manage gpu/vgpu devices.