Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for harvester-seeder helm chart #139

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

ibrokethecloud
Copy link
Contributor

Introduction of base chart for harvester-seeder

Related to: harvester/harvester#2318

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

charts/harvester-seeder/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/harvester-seeder/templates/rbac.yaml Outdated Show resolved Hide resolved
charts/harvester-seeder/values.yaml Outdated Show resolved Hide resolved
charts/harvester-seeder/templates/rbac.yaml Outdated Show resolved Hide resolved
add default for embedded mode in seeder chart

update image to main-head for master branch

fix rbac for hardware

drop node selector for beta.kubernetes.io/os

changes based on feedback on PR

fix chart linting errors
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit 6e4492c into harvester:master Jun 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants