Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, tests and docs for Exceptions and Errors #82

Open
psarka opened this issue Jan 17, 2022 · 0 comments
Open

Cleanup, tests and docs for Exceptions and Errors #82

psarka opened this issue Jan 17, 2022 · 0 comments

Comments

@psarka
Copy link
Collaborator

psarka commented Jan 17, 2022

The issue #72 was caused by 0.16.1 raising different exception than 0.16 - TypeError instead of threading.ThreadError. The former does not inherit from Exception, so duplicity failed to intercept it when releasing the lock twice (they always release the lock twice).

We need tests to make sure we maintain the exception interface, as well as docs. And ideally we should not be raising threading.ThreadError, as processes have nothing to do with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant