Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FID column on Performance tab #229

Closed
pedddro opened this issue Jul 16, 2024 · 5 comments
Closed

Remove FID column on Performance tab #229

pedddro opened this issue Jul 16, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@pedddro
Copy link
Contributor

pedddro commented Jul 16, 2024

Details

FID will be sunset in favor of INP, which is only available on other lighthouse modes, not the one used in UNLH.

@harlan-zw harlan-zw added enhancement New feature or request v1 and removed v1 labels Sep 29, 2024
@harlan-zw
Copy link
Owner

Thanks for the issue and sorry for the delay.

I agree it should be replaced with INP but there's no reliable way to test INP in a lighthouse environment without the end-users providing a bunch of potentially confusing config.

For now, I'll just add a warning icon on this column letting people know it's deprecated.

image

In v1 I hope to support other modes OR hook into using CrUX data for each route.

harlan-zw added a commit that referenced this issue Sep 29, 2024
@pedddro
Copy link
Contributor Author

pedddro commented Sep 30, 2024

Thanks for the issue and sorry for the delay.

I agree it should be replaced with INP but there's no reliable way to test INP in a lighthouse environment without the end-users providing a bunch of potentially confusing config.

For now, I'll just add a warning icon on this column letting people know it's deprecated.

image

In v1 I hope to support other modes OR hook into using CrUX data for each route.

i think you should fully remove, if any TBT is a better predecessor of INP than FID.

@harlan-zw
Copy link
Owner

harlan-zw commented Oct 1, 2024

TBT is already shown, ideally I have something to replace FID

@pedddro
Copy link
Contributor Author

pedddro commented Oct 1, 2024

TBT is already shown, ideally I have something to replace FID

I don't understand why you need to have something to replace FID.

No one used it and the passing rate was +95% before the deprecation.

@harlan-zw
Copy link
Owner

just to make the columns evenly spaced 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants