Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom functions guide is outdated #968

Closed
sequba opened this issue Apr 15, 2022 · 1 comment · Fixed by #1000
Closed

Custom functions guide is outdated #968

sequba opened this issue Apr 15, 2022 · 1 comment · Fixed by #1000
Assignees
@sequba
Labels
Bug Something isn't working Docs Improvements or additions to documentation Impact: High Released

Comments

@sequba
Copy link
Contributor

sequba commented Apr 15, 2022 •
edited
Loading

Description

From #965 we learned that the guide gives inaccurate information. It must be updated.

Some changes in the production code might also be needed. E.g. a custom function should work without parameters provided in the metadata:

hyperformula/src/interpreter/plugin/FunctionPlugin.ts

Line 48 in 38e31a7

parameters?: FunctionArgument[],

Steps to reproduce

  1. Try to implement a function following the guide
  2. Fail

Demo

Included in #965

Links

#965
#779
#957
@sequba sequba added Bug Something isn't working Docs Improvements or additions to documentation labels Apr 15, 2022
This was referenced Apr 15, 2022
Closed
Closed
@sequba sequba self-assigned this May 25, 2022
@sequba sequba mentioned this issue Jun 1, 2022
Merged
7 tasks
sequba added a commit that referenced this issue Jun 4, 2022
@sequba
Add entry #968 to changelog
29b5f1a
sequba added a commit that referenced this issue Jun 10, 2022
@sequba
Update custom-functions guide (#1000)
34127eb 
* Additional test for SUMIF with array arithmetics

* Additional test for VLOOKUP when there are multiple matching rows

* Improve formatting in custom-functions.md

* Create a step-by-step guide of the simplest possible custom function

* More unit tests for IF function

* Fix misinformation in the custom-functions.md guide

* Add entry #968 to changelog

* Tests for SUMIF and SUMIFS with inline array as criterion

* Convert full code example from Typescript to Javascript

Co-authored-by: Jakub Wiśniewski <[email protected]>
@sequba sequba mentioned this issue Jun 14, 2022
Merged
4 tasks
@sequba
Copy link
Contributor Author

sequba commented Jun 21, 2022

Released with 2.0.1

@sequba sequba closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sequba sequba

Labels
Bug Something isn't working Docs Improvements or additions to documentation Impact: High Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update custom-functions guide handsontable/hyperformula
2 participants
@sequba @AMBudnik