Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock DNS records for tests #812

Open
nodech opened this issue May 22, 2023 · 0 comments
Open

Add mock DNS records for tests #812

nodech opened this issue May 22, 2023 · 0 comments

Comments

@nodech
Copy link
Contributor

nodech commented May 22, 2023

The tests for the claims and anything related to it take too much time, because the requests depend on the response from the actual servers using stub resolver.

  • It's performance depends on the stub server performance (e.g. 8.8.8.8 in bns)
  • It depends on the DNS Records in those names (e.g. cloudflare) to have proper DNS records.

Ideally, we would have ability to mock the whole server. Proper place is probably the bns for this. (e.g. chjj/bns#34)

Alternatively, restructure Ownership/DNSProof in the ownership to have ability to mock the prov/verify for both the ownership and the proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant