From 3b95abe4788126e92fbd47f1b5d20b4fd2368025 Mon Sep 17 00:00:00 2001 From: Will Handley Date: Thu, 18 Apr 2024 12:56:03 +0100 Subject: [PATCH 1/3] Updated the PULL_REQUEST_TEMPLATE.md to mention black and isort --- PULL_REQUEST_TEMPLATE.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..5d70b3c --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,15 @@ +# Description + +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. + +Fixes # (issue) + +# Checklist: + +- [ ] I have performed a self-review of my own code +- [ ] My code is black compliant (`black . --check`) +- [ ] My code is isort compliant (`isort . --profile black --filter-files`) +- [ ] My code contains compliant docstrings (`pydocstyle --convention=numpy unimpeded`) +- [ ] New and existing unit tests pass locally with my changes (`python -m pytest`) +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] I have appropriately incremented the [semantic version number](https://semver.org/) in both README.rst and unimpeded/_version.py From 9f353440a08e85caf50fd238fd418354870c65c9 Mon Sep 17 00:00:00 2001 From: Will Handley Date: Thu, 18 Apr 2024 12:56:05 +0100 Subject: [PATCH 2/3] bump version to 0.2.4 --- README.rst | 2 +- unimpeded/_version.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index b492c37..8e1c0c3 100644 --- a/README.rst +++ b/README.rst @@ -3,7 +3,7 @@ unimpeded: Universal model comparison & parameter estimation distributed over ev =========================================================================================== :unimpeded: Universal model comparison & parameter estimation distributed over every dataset :Author: Will Handley -:Version: 0.2.3 +:Version: 0.2.4 :Homepage: https://github.com/handley-lab/unimpeded :Documentation: http://unimpeded.readthedocs.io/ diff --git a/unimpeded/_version.py b/unimpeded/_version.py index d31c31e..788da1f 100644 --- a/unimpeded/_version.py +++ b/unimpeded/_version.py @@ -1 +1 @@ -__version__ = "0.2.3" +__version__ = "0.2.4" From 474bb08f73b0240464f159badd9574e1e5763359 Mon Sep 17 00:00:00 2001 From: Will Handley Date: Thu, 18 Apr 2024 16:29:10 +0100 Subject: [PATCH 3/3] Updated request template and code style --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- .github/workflows/code_style.yaml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a3ee333..5d70b3c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,8 @@ Fixes # (issue) # Checklist: - [ ] I have performed a self-review of my own code -- [ ] My code is PEP8 compliant (`flake8 unimpeded tests`) +- [ ] My code is black compliant (`black . --check`) +- [ ] My code is isort compliant (`isort . --profile black --filter-files`) - [ ] My code contains compliant docstrings (`pydocstyle --convention=numpy unimpeded`) - [ ] New and existing unit tests pass locally with my changes (`python -m pytest`) - [ ] I have added tests that prove my fix is effective or that my feature works diff --git a/.github/workflows/code_style.yaml b/.github/workflows/code_style.yaml index fb140b1..32273ff 100644 --- a/.github/workflows/code_style.yaml +++ b/.github/workflows/code_style.yaml @@ -46,4 +46,4 @@ jobs: - name: Install pydocstyle run: pip install pydocstyle - name: run pydocstyle - run: python -m pydocstyle --convention=numpy anesthetic + run: python -m pydocstyle --convention=numpy unimpeded