Fail hanami db drop when cannot check database existence

[katafrakt]

Currently if the existence check for a database fails (for example due to whole database server being down or user not existing), Hanami CLI will anyway return information that the database was dropped.

This changes it to failing with an explicit error message in such case. Examples:

$ hanami db drop
Could not check if the database exists. Error message:
psql: error: connection to server at "localhost" (::1), port 5432 failed: Connection refused
	Is the server running on that host and accepting TCP/IP connections?
connection to server at "localhost" (127.0.0.1), port 5432 failed: Connection refused
	Is the server running on that host and accepting TCP/IP connections?

$ hanami db drop
Could not check if the database exists. Error message:
psql: error: connection to server at "localhost" (::1), port 5432 failed: FATAL:  database "katafrakt" does not exist

Addresses #275

[KamilMilewski]

What's the status of this PR? Lately I encountered same issue and independently came up with pretty much same fix as in this PR 😄 thus asking. Would be nice to have it merged because current behavior can be very confusing.

[kyleplump]

thanks for the nudge @KamilMilewski!

@katafrakt - this looks nice to me. should we implement the same behavior with the other two connection types? (mysql, sqlite)

[katafrakt]

@kyleplump for SQLite the check is just File.exist?, so we cannot distinguish between database not existing and not being able to check it. But it seems it would make sense for MySQL. I can implement it, but first I would have to figure out installing MySQL to check it. Haven't really done it in a decade or so 😅

[katafrakt]

Added for MySQL now.

Before:

$ be hanami db drop
=> database hanysql dropped
=> database hanysql_test dropped

After:

$ be hanami db drop
Could not check if the database exists. Error message:
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
ERROR 1698 (28000): Access denied for user 'root'@'localhost'

(also the warning hints some potential problems in the future, but that's out of scope)

[kyleplump]

thanks @katafrakt!

[kyleplump]

thanks again @katafrakt - sorry missed it on the first pass, but have one update. can we also add spec coverage for the new error? past that lgtm!

[katafrakt]

@kyleplump specs added

[kyleplump]

appreciate it @katafrakt!