Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Number Limit #10

Open
proffnick opened this issue Jul 23, 2021 · 4 comments
Open

Card Number Limit #10

proffnick opened this issue Jul 23, 2021 · 4 comments

Comments

@proffnick
Copy link

Please how do I extend the card number limit from 16 to say 19 ? I have a verve card of 19 digits and I was surprised I could not use it on the package.

Thank you for your help.

@halilb
Copy link
Owner

halilb commented Jul 23, 2021

Hi @proffnick,

I've tested the library with popular card types and this is the first time I'm hearing about Verve cards. You may fork the library and add support for that type. PRs are also welcomed.

@proffnick
Copy link
Author

Hi @proffnick,

I've tested the library with popular card types and this is the first time I'm hearing about Verve cards. You may fork the library and add support for that type. PRs are also welcomed.

I could have but unfortunately for me it is written in typescript, which I am not too familiar with. But I will see what I can do about it.
Thank you for the reply.

@tons613
Copy link
Contributor

tons613 commented Nov 14, 2021

Hi @halilb , It will be a great idea if this is implemented. I have users that uses verve cards too, and I am having this same issue too.

@halilb
Copy link
Owner

halilb commented Nov 15, 2021

Hi @halilb , It will be a great idea if this is implemented. I have users that uses verve cards too, and I am having this same issue too.

Thanks for the input @tons613. I'm afraid I don't have time to implement this nowadays. I'd love to review and merge a PR about this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants