Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize compute.mooring_volume_transport #363

Open
ThomasHaine opened this issue May 25, 2023 · 2 comments
Open

Generalize compute.mooring_volume_transport #363

ThomasHaine opened this issue May 25, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ThomasHaine
Copy link
Collaborator

I'm interested in generalizing the functionality provided by compute.mooring_volume_transport. I want to also compute property transports, like heat transport or salt transport etc.

Ideally, I want this function to work using a mooring path to minimize interpolation errors. E.g., I want to compute the boundary heat fluxes across a control volume in the ECCO dataset by integrating the ADV{x,y,r}_TH fields. For other datasets (like LLC_4320) there would need to be an interpolation step to compute Temp on the mooring path.

I don't think this functionality exists in OceanSpy currently, right?

If not, adapting compute.mooring_volume_transport seems like a good option. We'd just need to pass an extra argument defining the intensive property to integrate. If necessary, there would be an interpolation step. Then the computation would be modified by multiplying with the property value.

Is this a good idea?

@ThomasHaine ThomasHaine added the enhancement New feature or request label May 25, 2023
@Mikejmnez
Copy link
Collaborator

I am very interested in this idea.

My understanding is that only volume transport is implemented, but like you said, it would be somewhat straightforward from there. Add a property value (temp, salt, perhaps momentum or even pv) plus a reference value.

@ThomasHaine ThomasHaine self-assigned this May 26, 2023
@ThomasHaine
Copy link
Collaborator Author

Good to hear. @asiddi24, @malmans2, @MaceKuailv any comments? If not, I'll explore what's involved and ask @Mikejmnez for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants