Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement finding the filters have been chosen #1860

Closed
Parisajf opened this issue Sep 19, 2024 · 4 comments
Closed

Implement finding the filters have been chosen #1860

Parisajf opened this issue Sep 19, 2024 · 4 comments

Comments

@Parisajf
Copy link
Member

Parisajf commented Sep 19, 2024

Dependency

Overview

As a user, I want to be able to see what filters and sorting I have chosen and what filters / sorting are selected by default so I understand my results better.

Action Items

Resources/Instructions

An example of how Google Sheets indicates selected filters
Link to "My Projects" page
Design Issue #1578
Link to Figma file
Link to the Figma Prototype for filtering UI

@amiteshsrivastava11
Copy link
Member

@NilakshiS @ExperimentsInHonesty It seems like we are addressing this by having the image be highlighted when someone is using the sort. If they choose multiple sorts, will all the icons be highlighted?

@amiteshsrivastava11 amiteshsrivastava11 moved this from New Issue Approval to Questions/Clarifications in P: TDM: project board Dec 10, 2024
@amiteshsrivastava11 amiteshsrivastava11 removed the Dependency Issues that cannot be worked on until another issue is closed label Dec 10, 2024
@NilakshiS
Copy link
Member

@amiteshsrivastava11 This issue was made to implement a design issue in the future, but the design issue was later closed as unplanned. The sorting icon is from a different design issue #1919 but I'm not sure if there's already an "implement" issue created for it. You can either edit the title and description of this issue to make it for #1919 or create a new one, if one does not exist.

Regarding multiple sorts: Multiple sorts (stable sort) are not possible currently and unplanned for now. We'll create a new design issue in the future if needed to find the best way to show multiple sort.

@NilakshiS
Copy link
Member

@amiteshsrivastava11 @ExperimentsInHonesty My bad, I thought stable sort was unplanned because of this stakeholder meeting slide where it says it's planned for post-launch but it seems John has already implemented it in issue #1981? Then should I create another issue to get designs for the multiple sorting?

@NilakshiS
Copy link
Member

@NilakshiS NilakshiS closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Questions/Clarifications to On Dev - not yet pushed to Prod in P: TDM: project board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Dev - not yet pushed to Prod
Development

No branches or pull requests

3 participants