Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation on how to apply changes from one file to another in GitHub #425

Open
3 of 14 tasks
shmonks opened this issue Oct 24, 2024 · 4 comments
Open
3 of 14 tasks
Labels
complexity: small All steps are laid out in detail so that someone new to the project can work on it dependency Issue has dependencies feature: docs: PD team documentation documentation on PD team processes and architecture, etc. ready for dev lead ready for product role: back end role: dev role: product s: PD team stakeholder: People Depot Team size: 0.25pt Can be done in 0.5-1.5 hours
Milestone

Comments

@shmonks
Copy link
Member

shmonks commented Oct 24, 2024

Dependency

  • Information missing on how to apply changes across files in GitHub

Overview

We need to make it easy to:

  • Record any missing documentation on how to apply changes across files in GitHub
  • Keep those records in one place
  • Create new issues based on those records

This issue is the place to record missing documentation and start creating related new issues.

Details

  • We are striving to write documentation that helps developers use GitHub.
  • This issue tracks the documentation that needs to be added on how to apply changes across files in GitHub. If you've noticed missing documentation about other Git and/or Django processes,
see the following issues instead

Action Items

  • For each piece of missing information, copy and paste the following template into a new comment below.
### Overview
We need to add [REPLACE WITH WHAT NEEDS ADDING], so that developers can [REPLACE WITH BENEFIT]

### Action Items
- [ ] [REPLACE WITH ACTION ITEMS]

### Resources/Instructions/Tags 

- 1.0x [REPLACE WITH LINKS TO ANY EXTERNAL DOCS THAT MIGHT BE USEFUL (WITH INSTRUCTIONS, IF NEEDED)]
- 1.0x [REPLACE WITH ANY RELEVANT TAGS e.g., git, django, etc.]

### Documentation Addition Notes
#### What's missing?
[REPLACE WITH DESCRIPTION OF WHAT'S MISSING FROM THE DOCUMENTATION]
   
#### Where should it go?
[REPLACE WITH URL OR INDICATE NEW PAGE AND PARENT PAGE]

####  When would this information have been useful?
[REPLACE WITH LINK TO THE PR/ISSUE/SITUATION THAT PROMPTED THE NEED FOR THIS CHANGE/ADDITION]
   
#### Which roles will benefit most from this information?
[REPLACE WITH ROLES]

  • Fill out as many of the template's fields as possible.
  • Copy and paste a link to your comment in Section 2: List of comments/issues about missing documentation on how to apply changes across files in GitHub below, using the next available number
  • Copy the content of your comment
  • Create a new issue, pasting the content of your comment into the new issue
  • Add the following labels to the new issue
    • feature: docs: PD team documentation
    • size: 0.25pt
    • s: PD team
    • ready for dev lead
    • choose a complexity label that fits
    • choose the role label that fits
  • When this new issue has been created, add a link to it in Section 2: List of comments/issues about missing documentation on how to apply changes across files in GitHub below. Make sure the link to your new issue appears beneath the link to your comment, so we can ensure that all comments get made into issues
  • Hide the original comment (you can mark it 'Resolved')

Section 2: List of comments/issues about missing documentation on how to apply changes across files in GitHub

@shmonks shmonks removed their assignment Oct 24, 2024
@shmonks

This comment was marked as outdated.

@shmonks shmonks removed the draft This issue is not fully-written label Oct 24, 2024
@shmonks

This comment was marked as resolved.

@shmonks shmonks added complexity: missing size: missing and removed good first issue Good for newcomers complexity: small All steps are laid out in detail so that someone new to the project can work on it size: 0.25pt Can be done in 0.5-1.5 hours labels Oct 24, 2024
@fyliu

This comment was marked as duplicate.

@shmonks shmonks added draft This issue is not fully-written dependency Issue has dependencies labels Oct 25, 2024
@shmonks shmonks self-assigned this Oct 28, 2024
@shmonks shmonks moved this from 🆕New Issue Review to 🏗In progress-actively working in P: PD: Project Board Oct 28, 2024
@shmonks shmonks added complexity: small All steps are laid out in detail so that someone new to the project can work on it size: 0.25pt Can be done in 0.5-1.5 hours and removed complexity: missing size: missing labels Oct 31, 2024
@shmonks
Copy link
Member Author

shmonks commented Oct 31, 2024

Overview

We need to add a description of how to apply changes from one GitHub file to another, so that developers can synchronize changes and keep files up-to-date.

Action Items

Resources/Instructions/Tags

1.01 git, diff, patch, moved content

Documentation Addition Notes

What's missing?

Here's how to apply changes from one GitHub file to another:

  1. Rebase/Merge your feature branch to main.

  2. Undo changes to the file you changed (replacing CONTRIBUTING.md with the relevant filename):

git reset upstream/main -- CONTRIBUTING.md
  1. Now switch to the unmerged branch with the changes (replacing our-branch-original with the relevant branch name):
git switch our-branch-original
  1. Create a patch of the changes (replacing with relevant filename):
git format-patch hackforla/main CONTRIBUTING.md
# only changes to CONTRIBUTING.md
# include changes since we branched off from hackforla/main
# may need to create a temporary branch where hackforla/main used to be for this command

# output:
# 0001-add-to-dev-environment.patch
  1. Switch to the rebased branch without the changes to the file (in this example CONTRIBUTING.md):
git switch our-branch-rebased
  1. Apply the patch to the other file (in this example, docs/contributing/dev_environment.md:
patch -p1 docs/contributing/dev_environment.md 0001-add-to-dev-environment.patch

Where should it go?

[REPLACE WITH URL OR INDICATE NEW PAGE AND PARENT PAGE]

When would this information have been useful?

  • This information would be useful in situations where complex changes have been made - for example::
  1. You made a change to CONTRIBUTING.md, unmerged.
  2. Another dev split CONTRIBUTING.md into several files and it's merged into main.
    • The place you made the change in CONTRIBUTING.md is now in a file called contributing/dev_environment.md
    • git can't merge your change automatically. (git tracks renames, but not splits)
  3. By using the patch described above to apply the change semi-automatically, you can avoid having to type (copy/paste) the change manually into contributing/dev_environment.md

Which roles will benefit most from this information?

  • Backend/Dev

@shmonks shmonks removed their assignment Oct 31, 2024
@shmonks shmonks added role: product ready for product and removed draft This issue is not fully-written labels Oct 31, 2024
@shmonks shmonks moved this from 🏗In progress-actively working to 📋Prioritized Backlog in P: PD: Project Board Oct 31, 2024
@vanessaavviles vanessaavviles self-assigned this Nov 1, 2024
@vanessaavviles vanessaavviles moved this from 📋Prioritized Backlog to 🏗In progress-actively working in P: PD: Project Board Nov 1, 2024
@shmonks shmonks moved this from 🏗In progress-actively working to 🧊Ice Box in P: PD: Project Board Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: small All steps are laid out in detail so that someone new to the project can work on it dependency Issue has dependencies feature: docs: PD team documentation documentation on PD team processes and architecture, etc. ready for dev lead ready for product role: back end role: dev role: product s: PD team stakeholder: People Depot Team size: 0.25pt Can be done in 0.5-1.5 hours
Projects
Status: 🧊Ice Box
Development

No branches or pull requests

3 participants