Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHPAGES-DOCKER needs to be updated #137

Open
gaylem opened this issue Aug 7, 2024 · 5 comments
Open

GHPAGES-DOCKER needs to be updated #137

gaylem opened this issue Aug 7, 2024 · 5 comments
Assignees
Labels

Comments

@gaylem
Copy link
Member

gaylem commented Aug 7, 2024

GitHub Pages is now using v232 of the GitHub Pages Ruby Gem. You are using v231. Please refer to the ghpages-docker Wiki for instructions on how to update.

@gaylem gaylem added feature: docker feature: maintenance role: Site Reliability Engineer aka Infrastructure Engineer size: 0.5pt Can be done in 3 hours or less labels Aug 7, 2024
@fyliu
Copy link
Member

fyliu commented Aug 14, 2024

I see #141 saying the gem is at v227 now. Did someone rebuild the image recently?

Would anyone mind if I clicked the button to see if it updates it like the instructions say?

I'll add a note and leave this alone if it takes much more than that, but I doubt it.

Update: it's definitely on pre-v229 if the ruby version is 2.7 . Here's the v229 changes where the ruby version went from 2.7.3 to 3.3

@danielridgebot
Copy link

danielridgebot commented Aug 15, 2024

I'm not sure what you mean by

Would anyone mind if I clicked the button to see if it updates it like the instructions say?

I don't know how the ops team works but would you or someone else be interested in working on these issues? If not, I would be willing to self-assign follow the instructions in https://github.com/hackforla/ghpages-docker/wiki#how-do-you-update-ghpages-docker (in my fork) then create a PR?

@fyliu
Copy link
Member

fyliu commented Aug 16, 2024

Hi @roslynwythe
I just commented because it looks like it wouldn't take too long to resolve (I hope). I think it's better that you did this if you're willing. I had a small part when Eric worked on the code to create the docker image, so I'm somewhat familiar with it. I'd be good if more people become familiar with it.

I guess the instructions on updating the gem by clicking the "Run workflow" button to trigger the workflow-dispatch won't work for this case because the gem now depends on a much newer ruby and that requires updating the code to rebuild the image.

I don't think I have write access to that repo, but if you create a PR that needs review, I can maybe ask for temporary permission? It feels like at least the website team leads should get write access to it.

@danielridgebot
Copy link

danielridgebot commented Aug 19, 2024

@fyliu
Copy link
Member

fyliu commented Aug 19, 2024

@roslynwythe that sounds right to me according to the update documentation. The gem should be automatically updated when the image is rebuilt. The only thing that needs doing seems to be updating the ruby images in the Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress (actively working)
Development

No branches or pull requests

4 participants