Skip to content

Create a Guide/Template: Implementing Tests with Your Code Changes #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 tasks
Tracked by #55
gregpawin opened this issue Apr 15, 2021 · 11 comments
Open
7 tasks
Tracked by #55

Create a Guide/Template: Implementing Tests with Your Code Changes #153

gregpawin opened this issue Apr 15, 2021 · 11 comments
Labels
Complexity: Missing CoP: Engineering CoP label: checked CoP labels have been checked CoP label: shortcuts added drive: shared with me files are in a 'shared with me' drive; unable to be moved because do not have ownership of files feature : guide creation milestone: missing Phase: 1 - Gather Examples Solo Ready for Bonnie Triage size: missing status: 1.1 needs wiki examples Gathering examples by checking each team's wiki status: 1.2 needs issues examples Gathering examples by checking each team's issues status: 1.3 needs project board examples Gathering examples by checking each team's project board cards status: 1.4 needs slack examples Check each team's slack channel for examples

Comments

@gregpawin
Copy link
Member

gregpawin commented Apr 15, 2021

Overview

We need to create a guide to best practices for implementing tests with your code changes.

Action Items

The phases in the guide-making process are listed below. Each phase displayed in blue is linked to a wiki page with instructions on how to complete that phase. Open the wiki page in a new tab, copy the instructions for each part into the section labeled 'Tasks' at the bottom of this issue, and complete each task listed.

Resources/Instructions

Google Drive Folder for this Guide’s documents and shortcuts (to documents in other locations) 0153 [DRAFT]Implementing Tests with Your Code Changes

Projects to Check

Tasks

  • This is where you will copy instructions from the wiki page for the step you are currently on.
@benrempel

This comment has been minimized.

@Aveline-art

This comment has been minimized.

@alan-zambrano

This comment has been minimized.

@seannwvong

This comment has been minimized.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty

This comment has been minimized.

@JesseTheCleric
Copy link
Member

Prior version of issue

Overview

We need to create a guide to best practices for implementing tests with your code changes.

Action Items

  • Gather examples of how other projects have done it, adding each example as a link in the resources section
    • Once done, remove the "TG: Gather Examples" label and add the "TG: Draft Template" label
  • Create a draft template, either in markdown format in this issue or a google doc in the Engineering google drive
    • Once done, remove the "TG: Draft Template" label and add the "TG: Create Guide" label
  • Create a guide on how to use the template
    • Once done, remove the "TG: Create Guide" label and add the "TG: Review Guide" label
  • Review the guide with engineering communities of practice
    • Once done, remove the "TG: Review Guide" label and add the "TG: Leadership Review" label
  • Present to Hack for LA leadership team for sign off
    • Once approved, remove the "TG: Leadership Review" label and add the "TG: Place Guide" label
  • Possibly create an issue template on .github
    • Include link to template under resources if you add it as a template in .github

Resources

Update tracker issue (TBD) with the name of item you are working

@JesseTheCleric
Copy link
Member

Assignee, Labels, Project Board Placement, and Milestones for this issue in the Engineering Repo:

Image

@JesseTheCleric
Copy link
Member

JesseTheCleric commented Feb 13, 2025

Files in this Issue

@fchan218

This comment has been minimized.

@fchan218

This comment has been minimized.

@Aditya23soni Aditya23soni transferred this issue from hackforla/engineering Mar 18, 2025
@Aditya23soni Aditya23soni added Phase: 1 - Gather Examples Solo status: 1.1 needs wiki examples Gathering examples by checking each team's wiki status: 1.3 needs project board examples Gathering examples by checking each team's project board cards status: 1.2 needs issues examples Gathering examples by checking each team's issues status: 1.4 needs slack examples Check each team's slack channel for examples size: missing milestone: missing labels Mar 18, 2025
@Aditya23soni Aditya23soni added Complexity: Missing feature : guide creation drive: shared with me files are in a 'shared with me' drive; unable to be moved because do not have ownership of files labels Mar 18, 2025
@fchan218 fchan218 added the CoP label: check needed need to check if the CoP labels are correct label Mar 28, 2025
@ExperimentsInHonesty ExperimentsInHonesty added CoP label: checked CoP labels have been checked CoP label: folder shortcut needed need to add google drive folder shortcut to CoP and removed CoP label: check needed need to check if the CoP labels are correct labels Apr 2, 2025
@Aditya23soni Aditya23soni added CoP label: shortcuts added and removed CoP label: folder shortcut needed need to add google drive folder shortcut to CoP labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing CoP: Engineering CoP label: checked CoP labels have been checked CoP label: shortcuts added drive: shared with me files are in a 'shared with me' drive; unable to be moved because do not have ownership of files feature : guide creation milestone: missing Phase: 1 - Gather Examples Solo Ready for Bonnie Triage size: missing status: 1.1 needs wiki examples Gathering examples by checking each team's wiki status: 1.2 needs issues examples Gathering examples by checking each team's issues status: 1.3 needs project board examples Gathering examples by checking each team's project board cards status: 1.4 needs slack examples Check each team's slack channel for examples
Development

No branches or pull requests