Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML components to MUI: ./src/components/auth/Auth.js #1626

Open
7 tasks
Tracked by #1617
trillium opened this issue Apr 9, 2024 · 6 comments
Open
7 tasks
Tracked by #1617

Update HTML components to MUI: ./src/components/auth/Auth.js #1626

trillium opened this issue Apr 9, 2024 · 6 comments

Comments

@trillium
Copy link
Member

trillium commented Apr 9, 2024

Overview

Review all components in ./src/components/Auth.js and replace all standard HTML components with applicable MUI components.

Action Items

  • Review components in: ./src/components/Auth.js and search for any standard HTML components.
    • IF all components are already updated to relevant MUI:
      • Comment on this issue that all components are already updated to MUI.
      • Close the issue & check the box associated with this issue on the MUI issue epic
      • Move on to the next MUI issue
    • IF standard HTML components are found in the file:
      • Replace these standard HTML components with applicable MUI components.
      • Make a PR for this file.
      • If you would like to continue working on MUI issues, move on to the next issue in the MUI epic
  • If you run into any questions, add a comment to the issue and tag "@trillium"

Resources

https://mui.com/base-ui/all-components/

@freaky4wrld
Copy link
Member

@spiteless the file has instances of elements, needs to be converted to MUI-components, was trying to locally run the dev-environment, but it's not running. As suggested have tried to run the backend and fronted separately but no signs of error except warning to update Browserslist


Browserslist: caniuse-lite is outdated. Please run:
[1]   npx update-browserslist-db@latest
[1]   Why you should do it regularly: https://github.com/browserslist/update-db#readme
[1] Compiled with warnings.
[1] 
[1] ./src/pages/ManageProjects.js
[1]   Line 46:6:   React Hook useCallback has a missing dependency: 'EventsApiService'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
[1]   Line 103:5:  React Hook useCallback has a missing dependency: 'EventsApiService'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

@JackHaeg JackHaeg changed the title ./src/components/auth/Auth.js Update HTML components to MUI on: ./src/components/auth/Auth.js Apr 30, 2024
@JackHaeg JackHaeg changed the title Update HTML components to MUI on: ./src/components/auth/Auth.js Update HTML components to MUI: ./src/components/auth/Auth.js Apr 30, 2024
@freaky4wrld
Copy link
Member

freaky4wrld commented May 11, 2024

@spiteless

  • Just want to confirm html components like <form>, <label>, <input> and <button> should be left alone??
  • Also the link provided in the issue redirects to Base UI instead of Material UI, is it the correct one?

@JackHaeg
Copy link
Member

@spiteless Can you please assist Nayan on the above question?

@JackHaeg
Copy link
Member

@spiteless Can you please respond to Nayan's questions above when you get a chance?

@trillium
Copy link
Member Author

It depends.

@JackHaeg
Copy link
Member

@trillium Nayan is no longer on the VRMS team, so I am planning on un-assigning Nayan from this issue and placing it back into the prioritized backlog.

@JackHaeg JackHaeg moved this from In progress to Prioritized Backlog in P: VRMS: Project Board Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

3 participants