-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Searching an address outside of an NC boundary silently fails #1840
Comments
I'm opening this up as ready to work on. Smaller than 1pt, skipping dev lead review. |
ETA Oct Oct 17 Thursday |
@ryanfchase I was able to have the marker placed, but did we want it to zoom in on the location? |
Adding this as a point of discussion for today's agenda. I'll add a response soon: |
Design team to discuss in breakouts this evening. Follow up coming after meeting is over. |
@bphan002 for now, when an address is provided outside of an NC, can we fly to that address with a zoom level of 9? Design will be working on a ticket to decide how to message to the user that the search did not fall within an NC. Please move this ticket to "In Progress" if this clarification is sufficient. Resources |
New ETA Friday Oct 25th EOD |
Overview
We need to fix a regression so that users can still look up addresses outside of NC boundaries.
Action Items
ncIdOfAddressSearch
is empty, still attempt to set the address state so that a geocoder pin is placedDev Resources
Useful Files and Components
onGeocoderResult(result)
Mapbox Docs
Resources/Instructions
Screen recording after proposed changes
[insert screenshot here]
The text was updated successfully, but these errors were encountered: