Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail generation script causes games to crash, causing generation to fail #2189

Open
recursiveforte opened this issue Aug 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@recursiveforte
Copy link
Member

The thumbnail generation script overrides some functions with no-ops when running games. For example, setTune, for games running within the script, is set to () => {}. This causes some thumbnails to fail to generate, as seen below, when the return values of these functions are accessed (in this case: playTune().end()

Screenshot 2024-08-19 at 13 12 29

Relevant file: src/integrations/thumbnail.ts

@recursiveforte recursiveforte added the bug Something isn't working label Aug 19, 2024
@JosiasAurel
Copy link
Contributor

JosiasAurel commented Aug 20, 2024

please can you link a game that crashes while a thumbnail is being generated? or even better, provide steps to reproduce

@recursiveforte
Copy link
Member Author

recursiveforte commented Aug 20, 2024

https://sprig.hackclub.com/gallery/Hey_Hay_Cow
The game crashes internally and returns the default confused Orpheus image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants