Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDN to documentation #74

Open
shapeh opened this issue Oct 13, 2023 · 4 comments
Open

Add CDN to documentation #74

shapeh opened this issue Oct 13, 2023 · 4 comments

Comments

@shapeh
Copy link

shapeh commented Oct 13, 2023

Hi

I suggest to update the docs with a link to the CDN, e.g. https://www.jsdelivr.com/package/npm/aspnet-client-validation

e.g.

Via CDN

<script src="https://cdn.jsdelivr.net/npm/aspnet-client-validation/dist/aspnet-validation.min.js" integrity="sha256-/PB6zFj7vHhLEgj9N93L5ls5YYCbREXwMGtQktTUDSI=" crossorigin="anonymous"></script>
@haacked
Copy link
Owner

haacked commented Jan 2, 2024

I like that idea, but I don't like that I have to remember to update the integrity attribute every single release in the readme. I'll need to think about how to make that not a big pain.

@shapeh
Copy link
Author

shapeh commented Jan 2, 2024

An idea is to include the CDN link but without integrity attribute. Then add a general note telling people to get the integrity attribute at the CDN provider/jsdelivr instead.

What do you think?

@haacked
Copy link
Owner

haacked commented Jan 2, 2024

Sounds good. Where exactly to do you find the integrity attribute? I'd want to provide a link.

@haacked
Copy link
Owner

haacked commented Jan 2, 2024

Also, feel free to submit a PR with the change to the README so you get the credit! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants