Form e.preventDefault() broken in Firefox (0.8.3-0.8.13)

[dotnetshadow]

Hi there,

It seems any code such as the following in Firefox breaks.
Chrome / Edge seem ok, but Firefox doesn't work

document.getElementById('my-form').addEventListener('submit', function (e) { e.preventDefault(); alert('This doesn't get called because the page navigates away'); });
The page just navigates away without being stopped

I tried various versions of the library and v0.8.1 is the last working version
0.8.3-0.8.13 BROKEN

@dahlbyk I noticed you made some changes during 0.8.3 release anything you can think of that would stop it form working in Firefox?

I suspect an issue with this part of the code
v0.8.1...v0.8.3#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R728

Any help would be much appreciated

[dahlbyk]

@dahlbyk I noticed you made some changes during 0.8.3 release anything you can think of that would stop it form working in Firefox?

Apparently #33 just doesn't work on Firefox. Here's a minimal repro and a proposed fix: https://codepen.io/dahlbyk/full/oNQQoMq.

In short, Firefox isn't firing submit listeners for the redispatch here:

aspnet-client-validation/src/index.ts

Lines 718 to 720 in f09bb57

	submitValidForm = (form: HTMLFormElement, submitEvent: SubmitEvent) => {
	const newEvent = new SubmitEvent('submit', submitEvent);
	if (form.dispatchEvent(newEvent)) {

Using setTimeout(fn, 0) seems to allow the original submit handler to finish before dispatching at the next opportunity.

If the Pen seems to work for you I'll submit a PR.

[dahlbyk]

I'll submit a PR.

Give #62 a try?

[dotnetshadow]

Thank you so much for fixing it, works great :)

[dahlbyk]

Ironically I just noticed this in https://ab.bot/ last night, prompting an upgrade. Thanks for finding it first. 😁