Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click should trigger an alternate file upload strategy #59

Open
AdamHolwerda opened this issue May 3, 2014 · 3 comments
Open

Click should trigger an alternate file upload strategy #59

AdamHolwerda opened this issue May 3, 2014 · 3 comments

Comments

@AdamHolwerda
Copy link

Drag and drop is great and all, but is it really easier / better? I have to resize all my windows and drag stuff around to even get to the point where I can drag more stuff into the window, and all I want to do is make a gif out of some files. I know the original intent was to mimic dropmocks, which I think it does a good job of, but it's clunky for "file structure first" folks

Intended behavior: if the page is empty and has no gif on it already, anything you click that isn't an obvious link fires a multiple file upload prompt. It would also be cool if it knew which probable order the image files should go in

@bgrins
Copy link
Member

bgrins commented May 3, 2014

I could see adding an input[type=file] (maybe below the 'Drag and Drop images here' box). I don't like auto opening a file picker on any click that isn't obviously a file prompt though.

The FileReaderJS object has a setupInput(node) function that will behave exactly like the drop zone does (https://github.com/h5bp/mothereffinganimatedgif/blob/master/assets/js/libraries/filereader.js#L96), so it shouldn't be too hard to add. If you want to put together a PR for it I can review.

@AdamHolwerda
Copy link
Author

What about only opening it when you click inside the Drag and Drop box? And just change the text to "Drag and Drop images here or click to upload"?

I can put together a PR but if someone else wanted to I'm sure they'd beat me to it (this is a lazy web request after all).

@Walkman100
Copy link
Contributor

What about only opening it when you click inside the Drag and Drop box? And just change the text to "Drag and Drop images here or click to upload"?

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants