Skip to content

Commit 6775e4e

Browse files
committed
TODOs
1 parent 708f702 commit 6775e4e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/quicly.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6821,6 +6821,9 @@ static quicly_error_t handle_ack_frequency_frame(quicly_conn_t *conn, struct st_
68216821
if (frame.max_ack_delay < QUICLY_LOCAL_MAX_ACK_DELAY * 1000 || frame.max_ack_delay >= (1 << 14) * 1000)
68226822
return QUICLY_TRANSPORT_ERROR_PROTOCOL_VIOLATION;
68236823

6824+
// TODO: use received frame.max_ack_delay. We currently use a constant (25 ms) and
6825+
// ignore the value set by our transport parameter (see max_ack_delay field comment).
6826+
68246827
if (frame.sequence >= conn->ingress.ack_frequency.next_sequence) {
68256828
conn->ingress.ack_frequency.next_sequence = frame.sequence + 1;
68266829
conn->application->super.packet_tolerance =

0 commit comments

Comments
 (0)