Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider injections as 'missed' in foundmissed if FAR is above a certain value #4488

Open
GarethCabournDavies opened this issue Sep 14, 2023 · 2 comments
Open

Consider injections as 'missed' in foundmissed if FAR is above a certain value #4488

GarethCabournDavies opened this issue Sep 14, 2023 · 2 comments
Assignees
@GarethCabournDavies
Labels
offline search

Comments

@GarethCabournDavies
Copy link
Contributor

Allow a user to set an IFAR at which any injections found below that value are considered as 'missed' in the same way as something which never had a coincidence at all

These injections would never be considered as 'found' if they were signals, so having 'missed' and 'IFAR < a certain value' as separate things seems counterintuitive
@titodalcanton
Copy link
Contributor

This has been done, right? Please link the PR…

@GarethCabournDavies
Copy link
Contributor Author

GarethCabournDavies commented Jan 10, 2024 •
edited
Loading

Nope, not done yet - this could probably be done as part of the PR to fix the sorting (#4601)

@GarethCabournDavies GarethCabournDavies self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GarethCabournDavies GarethCabournDavies

Labels
offline search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titodalcanton @GarethCabournDavies