Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection placement and efficiency calculation code for PyGRB Suggestions #4448

Open
rpfisher opened this issue Jul 27, 2023 · 1 comment
Open
Labels
PyGRB PyGRB development

Comments

@rpfisher
Copy link
Contributor

In order to solve the problems with inaccurate efficiency calculations, I have two ideas that I think should be implemented in the O4 pipeline (these may already be in or not, I need to learn about it)

  1. Injections that are used in the efficiency calculation should not be placed in data that has been gated/autogated
  2. Injections that are missed due to failing the X^2 tests should not be counted in the calculation of the exclusion distance and the efficiency curves:
    a. The calculation of the exclusion distance is meant to indicate the effective range to which we could detect a GW. This should be a continuous drop off in efficiency as the distance is increased. Due to the design of the search, unless we were to request deglitched frames, whether or not there is a glitch overlaying a given injection (or onsource) is effectively a binary selection effect, not continuous. This does not match the goal of the calculation if we treat these times as if they are part of the continuum of the sensitivity of the search. This change would not mean we are handling the injections differently than the onsource: If there is a glitch in the onsource, we would cut and have no detection regardless of the range, unless the event is extremely loud, in which case it will have been detected in low latency already.
@rpfisher rpfisher changed the title Injection placement code for PyGRB Suggestions Injection placement and efficiency calculation code for PyGRB Suggestions Jul 27, 2023
@jakeb245 jakeb245 added the PyGRB PyGRB development label Jul 27, 2023
@github-project-automation github-project-automation bot moved this to In Progress in PyGRB Development Jul 27, 2023
@jakeb245 jakeb245 moved this from In Progress to Todo in PyGRB Development Jul 27, 2023
@rpfisher
Copy link
Contributor Author

@titodalcanton @pannarale @jakeb245 I think this could be added to the board of things to include in the O4 pipeline, but I think we should get your thoughts on my reasoning.

Also, I have no permissions to label these issues or add things to the board. I'd like to get them if possible, even though Jacob's doing all the work for now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Todo
Development

No branches or pull requests

2 participants