Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Day 2 review #31

Open
1 of 2 tasks
martinberoiz opened this issue Apr 2, 2025 · 1 comment
Open
1 of 2 tasks

Tutorial Day 2 review #31

martinberoiz opened this issue Apr 2, 2025 · 1 comment

Comments

@martinberoiz
Copy link
Contributor

martinberoiz commented Apr 2, 2025

  • In Day 2, the tutorials are referencing the PyCBC modules web page. A more inclusive top level links is here, also note the User Guides on left side of page that may be particularly applicable.
  • In Day 2, Tutorial 1,2,3 there are import pylab statements. According to matplotlib, direct input of pylab is 'strongly discouraged'. Given that the use of this python package seems to be working so far, if the change to use matplotlib.pylab is adopted, it should be rigorously tested. Also, the first time I imported pylab it took a long time, probably for some of the reasons noted in the matplotlib page above. DONE (see Remove pylab #35)
This was referenced Apr 4, 2025
@duboism
Copy link
Contributor

duboism commented Apr 10, 2025

Part of this were fixed in #35.

@duboism duboism mentioned this issue Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants