Skip to content

Conversation

@william-Dic
Copy link

No description provided.

@rangehow
Copy link
Collaborator

rangehow commented May 29, 2025

Hi @william-Dic ,

Thanks so much for submitting PR #152 and for your interest in improving this! We really appreciate you taking the time to contribute.

It looks like your changes in PR #152 are intended as improvements or modifications to the work already started in PR #151

To keep the discussion and changes consolidated, and to give @Hua-Wu-Que-Code a chance to directly incorporate your valuable feedback, would you be open to contributing your suggestions directly to their PR?

There are a couple of ways you could do this:

  1. You could comment on PR Create using_vllm_as_llm.py #151 with your suggestions, perhaps including a diff or a code snippet of your changes.
  2. you could fork their repository, apply your changes to that branch, and then open a new PR directly against @Hua-Wu-Que-Code's branch. They could then merge your changes into their branch, which would update PR Create using_vllm_as_llm.py #151 automatically.

This way, all related changes stay together, and @Hua-Wu-Que-Code can review and merge your improvements into their original submission.

Thanks again for your contribution!

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants