Improve pos_embed calculation #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `rpe_bucket` `nn.Parameter` to avoid copying in forward Use a single linear to calculate `pos_q` and `pos_k` to increase forward speed
guolinke
reviewed
Nov 12, 2021
| @@ -127,8 +127,7 @@ def __init__( | |||
| self.attn_scale_factor = 2 | |||
| self.num_attention_heads = num_attention_heads | |||
| self.pos = nn.Embedding(self.max_seq_len + 1, self.embedding_dim) | |||
| self.pos_q_linear = nn.Linear(self.embedding_dim, self.embedding_dim) | |||
| self.pos_k_linear = nn.Linear(self.embedding_dim, self.embedding_dim) | |||
| self.pos_proj = nn.Linear(self.embedding_dim, self.embedding_dim * 2) | |||
There was a problem hiding this comment.
this will break backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
rpe_bucketnn.Parameterto avoid copying in forwardUse a single linear to calculate
pos_qandpos_kto increase forward speed