Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some things to review #23

Open
23 of 26 tasks
Tracked by #60
rmed opened this issue Jan 27, 2015 · 11 comments
Open
23 of 26 tasks
Tracked by #60

Some things to review #23

rmed opened this issue Jan 27, 2015 · 11 comments

Comments

@rmed
Copy link
Member

rmed commented Jan 27, 2015

  • Upgrade RoR before Rails 5
  • Add identicons avatar support.
  • Remove nesting from comments
  • Review event forms
  • Show language selector in header
  • Add missing locales
  • Review readme
  • Review API and API docs (check this out apidocjs.com)
  • Update some icons theme (Awesome Icons)
  • Add more info messages between [form] transitions.
  • Merge Activities table with Activities without speaker table into a single table.
  • Show OpenStreetMap properly (desktop vew) 💩
  • Update Capistrano or switch to other/simple deployment tool 😩 (See mina) (Needs review, asigned to @mvaello)
  • Create release 1.0.1b or 1.5.0b 2.0.0b > 2.1.0
  • ~~Improve/fix meta tags (SEO/Social Sharing) (see ogp.me) & (meta-tags)(https://github.com/kpumuk/meta-tags) (In progress, asigned to @mvaello) ~~ (DUPLICATED)
  • Add token-based event edition (provide link to speaker/s)
  • Add Markdown support for comments and events (@yagop) (implemented by @mvaello)
  • Add preview button during event fill. Show the preview in a simple modal window before submit the event.
  • Improve and fix email messages
  • Convert old database to the new structure to show the past editions.
  • Substitute ActiveAdmin with RailsAdmin or better.
  • Revamp calendar view. (In progress, asigned to @mvaello)
  • Enhance UX and design (In progress, asigned to @mvaello)
  • Cleanup locales and include some forgoten strings. (DUPLICATED)
  • Add GUL shield (the lynx head) in the header (See sprockets-svg) (In progress, asigned to @mvaello)
  • Add statistics page (see chartist-js)
@mvaello
Copy link
Member

mvaello commented Mar 15, 2015

  • Added Travis CI.

@mvaello
Copy link
Member

mvaello commented Mar 19, 2015

  • Add tests :D

@yagop
Copy link
Contributor

yagop commented Mar 19, 2015

How about user signup and login? To edit his own events

@mvaello
Copy link
Member

mvaello commented Mar 19, 2015

"No users" This thing was a very early requirement in the project hence there are no plans for implement this. But, OTOH this is a thing that I have been thinking for long time and the conclusion reached is: a unique key delivered to the speaker's email could solve the issue because this key should be submitted in order to edit the event. Any comments/thoughts about that?

@yagop
Copy link
Contributor

yagop commented Mar 20, 2015

Who the hell wrote that requirement? A gardener? A system administrator? 😆
Welcome to the XXI century, were people mistakes and need to edit things. This is something formal, not a warez forum where people regrets signing up.

A random generated token (unique key) would be nice, the token should be associated to an email. But this is a user and a password for it, isn't it?
The random token (unique key/password) could be delivered to the speaker's email once he submit the event.

@yagop
Copy link
Contributor

yagop commented Mar 20, 2015

Add: Notifications when someone writes a comment on yours event.

@yagop
Copy link
Contributor

yagop commented Mar 20, 2015

Add: Markdown or any markup language for Description and/or comments. Check this out.

@mvaello
Copy link
Member

mvaello commented Mar 20, 2015

Yes, maybe a sysadmin... To be precise was @queltosh , you have to argue this issue with him :). You have to keep in mind that the app is used a couple times per year more or less, and store users in the DB would be useless and maybe risky. The token is a definitely easier, for the speaker and for us, because we don't have a profile itself with a username, password, other info, etc just a token associated to your email, but of course I know that is nearly the same. And of course the random key is delivered after submit an event or after click the accept link in the email.

@yagop
Copy link
Contributor

yagop commented Mar 20, 2015

Store users on a database is useless and risky? @guluc3m/owners are storing mail lists passwords on plain text and nobody gives a fuck... But this is not the topic now.

I am agree with token based authentication and it would be nice to use the same token for the API to make authenticated requests.

@rmed
Copy link
Member Author

rmed commented Mar 20, 2015

I'm not too keen on the idea of having users (apart from admins or assistants), just saying. Also, there is no implementation for performing authenticated requests in place.

@yagop
Copy link
Contributor

yagop commented Mar 31, 2015

Improve email templates and fix <a href="... code

http://i.imgur.com/Z5g5zNI.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants