Skip to content

MenuBar improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 4 tasks
tznind opened this issue May 8, 2022 · 1 comment
Open
1 of 4 tasks

MenuBar improvements #5

tznind opened this issue May 8, 2022 · 1 comment

Comments

@tznind
Copy link
Collaborator

tznind commented May 8, 2022 •
edited
Loading

The following issues need workarounds or additions

  • Deleting the last menu item from a root menu results in gui.cs throwing index out of bounds errors
  • There should be a way to rename root menus (change Title)

Other nice to haves

  • Reordering root menu headings
  • Move a menu item from one root menu to another (e.g. from File menu to View menu)
tznind pushed a commit that referenced this issue Dec 19, 2023
@dodexahedron
Relevant item for #5 - OperationManager.undoStack -> internal
4ffa1ea
tznind pushed a commit that referenced this issue Dec 19, 2023
@dodexahedron
Relevant item for #5 - OperationManager.undoStack -> internal
878c13d
tznind pushed a commit that referenced this issue Dec 19, 2023
@dodexahedron
Squashed 10 commits
bee99b0 
Use the generic create for these

Can do this in one call

Require new() on these

Add Label to the generic and use it

Add check to the generic method

Add default sizes to all

Generic supports TabView - Use it

Make these static and call RoundTrip like the static it is (now)

Minor clean-up and use pattern matching

A bunch of minor non-functional clean-up type changes done automatically

Explicit accessibility qualifiers
Some redundant ToStrings removed
Remove a bunch of unneeded usings
Some other redundancies like unused string interpolation removed

#5
#15
And possibly others
@tig
Copy link

tig commented May 21, 2024

See gui-cs/Terminal.Gui#2975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tig @tznind