Support combining sequences that don't normalize #2616
Labels
Milestone
Comments
22 tasks
8 tasks
tig
added a commit
that referenced
this issue
Oct 29, 2023
…malize (#2932) * Fixes #2616. Support combining sequences that don't normalize * Decouples Application from ConsoleDriver in TestHelpers * Updates driver tests to match new arch * Start on making all driver tests test all drivers * Improves handling if combining marks. * Fix unit tests fails. * Fix unit tests fails. * Handling combining mask. * Tying to fix this unit test that sometimes fail. * Add support for combining mask on NetDriver. * Enable CombiningMarks as List<Rune>. * Prevents combining marks on invalid runes default and space. * Formatting for CI tests. * Fix non-normalized combining mark to add 1 to Col. * Reformatting for retest the CI. * Forces non-normalized CMs to be ignored. --------- Co-authored-by: Tig <[email protected]>
tig
added a commit
that referenced
this issue
Jan 5, 2024
…uences (#3094) * Fixes #2616. Support combining sequences that don't normalize * Decouples Application from ConsoleDriver in TestHelpers * Updates driver tests to match new arch * Start on making all driver tests test all drivers * Improves handling if combining marks. * Fix unit tests fails. * Fix unit tests fails. * Handling combining mask. * Tying to fix this unit test that sometimes fail. * Add support for combining mask on NetDriver. * Enable CombiningMarks as List<Rune>. * Prevents combining marks on invalid runes default and space. * Formatting for CI tests. * Fix non-normalized combining mark to add 1 to Col. * Reformatting for retest the CI. * Forces non-normalized CMs to be ignored. * Initial experiment * Created ANSiDriver. Updated UI Catalog command line handling * Fixed ForceDriver logic * Fixed ForceDriver logic * Updating P/Invoke * Force16 colors WIP * Fixed 16 colo mode * Updated unit tests * UI catalog tweak * Added chinese scenario from bdisp * Disabled AnsiDriver unit tests for now. * Code cleanup * Initial commit (fork from v2_fixes_2610_WT_VTS) * Code cleanup * Removed nativemethods.txt * Removed not needed native stuff * Code cleanup * Ensures command line handler doesn't eat exceptions --------- Co-authored-by: BDisp <[email protected]>
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this issue
Jan 5, 2024
…uences (gui-cs#3094) * Fixes gui-cs#2616. Support combining sequences that don't normalize * Decouples Application from ConsoleDriver in TestHelpers * Updates driver tests to match new arch * Start on making all driver tests test all drivers * Improves handling if combining marks. * Fix unit tests fails. * Fix unit tests fails. * Handling combining mask. * Tying to fix this unit test that sometimes fail. * Add support for combining mask on NetDriver. * Enable CombiningMarks as List<Rune>. * Prevents combining marks on invalid runes default and space. * Formatting for CI tests. * Fix non-normalized combining mark to add 1 to Col. * Reformatting for retest the CI. * Forces non-normalized CMs to be ignored. * Initial experiment * Created ANSiDriver. Updated UI Catalog command line handling * Fixed ForceDriver logic * Fixed ForceDriver logic * Updating P/Invoke * Force16 colors WIP * Fixed 16 colo mode * Updated unit tests * UI catalog tweak * Added chinese scenario from bdisp * Disabled AnsiDriver unit tests for now. * Code cleanup * Initial commit (fork from v2_fixes_2610_WT_VTS) * Code cleanup * Removed nativemethods.txt * Removed not needed native stuff * Code cleanup * Ensures command line handler doesn't eat exceptions --------- Co-authored-by: BDisp <[email protected]>
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See this discussion for more: #2939
What's broken today (v2):
/u0301at column 0 renderśeven though/u0301is a zero-width codepoint.a/u0301works becauseConsoleDrivernormalizes itáa/u301/u0301doesn't work.ConsoleDrivernormalizes it toáand ignores the 2nd/u0301.WindowsDriverWriteConsoleOutput(whatWindowsDrivercurrently does).WindowsDrivercurrently outputs non-BMP characters asRune.ReplacementCharCursesDriver*NetDriverNote,
TextView/TextFieldand other input views do not handle any of this stuff correctly (mostly).Related:
ConsoleDrivers to support ANSI sequences natively (e.g. Virtual Terminal Sequences on Windows) #2610The text was updated successfully, but these errors were encountered: