Skip to content

MenuBar: Support Title so that a Window (with wasteful border) is not needed to show app title #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #2975
tig opened this issue Oct 19, 2022 · 4 comments

Comments

@tig
Copy link
Collaborator

tig commented Oct 19, 2022

Something like this:

image

But, make it obvious that "Notepad" is not part of the menu.

Perhaps right align the title? Might be weird.

Perhaps, a different color?

Perhaps, a different background color?

Perhaps, just a dash after? (Notepad -)?

@tznind
Copy link
Collaborator

tznind commented Oct 20, 2022

What about something like this:

menubartitle

The layout would need to be:

Align center (as above) unless:

  • If menus fill whole horizontal space then hide title
    hidetitle

  • If menus go past half way (i.e. would overlap title) then align title right instead of center
    alignright

@tznind
Copy link
Collaborator

tznind commented Oct 20, 2022

Perhaps, just a dash after? (Notepad -)?

Adding dashes does look pretty cool. Probably should be optional or just a convention we use in UICatalog (i.e. Title="-mytitle-") and recommend.

hyphentitle

@tig
Copy link
Collaborator Author

tig commented Oct 20, 2022

Great ideas @tznind -

FWIW, while I should be working on higher-priority stuff, I sucked myself into the Menu and MenuTests code yesterday. I am doing a major refactoring of the tests because they are super fragile. This will (hopefully) enable updating a bunch of this stuff easily.

@tig
Copy link
Collaborator Author

tig commented Aug 6, 2024

Closing. This will be addressed in #2975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants