Skip to content

Conversation

@andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented Oct 27, 2025

What are you changing?

Why?

  • DCAR uses a palette that defines its colours as CSS variables and passes this to the button theme. Since this value is resolved in CSS the hover colour function did not have access to what the background colour of the button was if passed this way.

@andrewHEguardian andrewHEguardian requested review from a team as code owners October 27, 2025 16:37
@andrewHEguardian andrewHEguardian added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Oct 27, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: fffcff2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Oct 27, 2025
@github-actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@andrewHEguardian andrewHEguardian force-pushed the ahe/calculate-hover-colour-css-var branch from b307271 to fffcff2 Compare October 27, 2025 16:39
@andrewHEguardian andrewHEguardian requested review from a team as code owners October 27, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐥 Canaries Triggers canary releases of any packages with changesets waiting. 📦 npm Affects a @guardian package on NPM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants