Skip to content

Commit dac05e5

Browse files
committed
create react-crossword package in workspace
and restore dev kitchen `Crossword` export to `main`
1 parent 79bfa61 commit dac05e5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+4961
-136
lines changed

.changeset/config.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,13 @@
88
"baseBranch": "main",
99
"updateInternalDependencies": "patch",
1010
"bumpVersionsWithWorkspaceProtocolOnly": false,
11-
"ignore": ["github-pages", "@configs/*", "coverage", "storybooks"],
11+
"ignore": [
12+
"github-pages",
13+
"@configs/*",
14+
"coverage",
15+
"storybooks",
16+
"@guardian/react-crossword"
17+
],
1218
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
1319
"onlyUpdatePeerDependentsWhenOutOfRange": true
1420
}

.github/workflows/chromatic-label-trigger.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ jobs:
1717
secrets:
1818
CHROMATIC_SOURCE_TOKEN: ${{ secrets.CHROMATIC_SOURCE_TOKEN }}
1919
CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN: ${{ secrets.CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN }}
20+
CHROMATIC_REACT_CROSSWORD: ${{ secrets.CHROMATIC_REACT_CROSSWORD }}

.github/workflows/chromatic.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ on:
77
required: true
88
CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN:
99
required: true
10+
CHROMATIC_REACT_CROSSWORD:
11+
required: true
1012

1113
jobs:
1214
deploy:
@@ -20,6 +22,8 @@ jobs:
2022
token: CHROMATIC_SOURCE_TOKEN
2123
- lib: source-development-kitchen
2224
token: CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN
25+
- lib: react-crossword
26+
token: CHROMATIC_REACT_CROSSWORD
2327
steps:
2428
- uses: actions/checkout@v4
2529
with:

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
secrets:
4545
CHROMATIC_SOURCE_TOKEN: ${{ secrets.CHROMATIC_SOURCE_TOKEN }}
4646
CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN: ${{ secrets.CHROMATIC_SOURCE_DEVELOPMENT_KITCHEN_TOKEN }}
47+
CHROMATIC_REACT_CROSSWORD: ${{ secrets.CHROMATIC_REACT_CROSSWORD }}
4748
if: |
4849
github.ref == 'refs/heads/main' ||
4950
contains(github.event.pull_request.labels.*.name, 'run_chromatic') ||

Makefile

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,42 @@ install: check-node-version
394394
@guardian/prettier\:tsc: env
395395
@corepack pnpm --filter @guardian/prettier tsc
396396

397+
.PHONY: @guardian/react-crossword\:build
398+
@guardian/react-crossword\:build: env
399+
@corepack pnpm --filter @guardian/react-crossword build
400+
401+
.PHONY: @guardian/react-crossword\:build-storybook
402+
@guardian/react-crossword\:build-storybook: env
403+
@corepack pnpm --filter @guardian/react-crossword build-storybook
404+
405+
.PHONY: @guardian/react-crossword\:dev
406+
@guardian/react-crossword\:dev: env
407+
@corepack pnpm --filter @guardian/react-crossword dev
408+
409+
.PHONY: @guardian/react-crossword\:fix
410+
@guardian/react-crossword\:fix: env
411+
@corepack pnpm --filter @guardian/react-crossword fix
412+
413+
.PHONY: @guardian/react-crossword\:lint
414+
@guardian/react-crossword\:lint: env
415+
@corepack pnpm --filter @guardian/react-crossword lint
416+
417+
.PHONY: @guardian/react-crossword\:storybook
418+
@guardian/react-crossword\:storybook: env
419+
@corepack pnpm --filter @guardian/react-crossword storybook
420+
421+
.PHONY: @guardian/react-crossword\:test
422+
@guardian/react-crossword\:test: env
423+
@corepack pnpm --filter @guardian/react-crossword test
424+
425+
.PHONY: @guardian/react-crossword\:tsc
426+
@guardian/react-crossword\:tsc: env
427+
@corepack pnpm --filter @guardian/react-crossword tsc
428+
429+
.PHONY: @guardian/react-crossword\:verify-dist
430+
@guardian/react-crossword\:verify-dist: env
431+
@corepack pnpm --filter @guardian/react-crossword verify-dist
432+
397433
.PHONY: @guardian/source\:build
398434
@guardian/source\:build: env
399435
@corepack pnpm --filter @guardian/source build

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ The following packages live in `libs/@guardian/*` and are published to NPM:
2424
- [@guardian/libs](libs/@guardian/libs)
2525
- [@guardian/newsletter-types](libs/@guardian/newsletter-types)
2626
- [@guardian/prettier](libs/@guardian/prettier)
27+
- [@guardian/react-crossword](libs/@guardian/react-crossword)
2728
- [@guardian/source](libs/@guardian/source)
2829
- [@guardian/source-development-kitchen](libs/@guardian/source-development-kitchen)
2930
- [@guardian/tsconfig](libs/@guardian/tsconfig)
@@ -161,6 +162,18 @@ Project-specific tasks are defined as `scripts` in their `package.json`, and can
161162
- `make @guardian/prettier:lint`
162163
- `make @guardian/prettier:tsc`
163164

165+
#### @guardian/react-crossword
166+
167+
- `make @guardian/react-crossword:build`
168+
- `make @guardian/react-crossword:build-storybook`
169+
- `make @guardian/react-crossword:dev`
170+
- `make @guardian/react-crossword:fix`
171+
- `make @guardian/react-crossword:lint`
172+
- `make @guardian/react-crossword:storybook`
173+
- `make @guardian/react-crossword:test`
174+
- `make @guardian/react-crossword:tsc`
175+
- `make @guardian/react-crossword:verify-dist`
176+
164177
#### @guardian/source
165178

166179
- `make @guardian/source:build`

apps/storybooks/.storybook/main.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ const config: StorybookConfig = {
2424
// port set in libs/@guardian/source-development-kitchen/package.json
2525
url: 'http://localhost:4402',
2626
},
27+
'react-crossword': {
28+
title: 'react-crossword',
29+
// port set in libs/@guardian/react-crossword/package.json
30+
url: 'http://localhost:4403',
31+
},
2732
};
2833
},
2934
};
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { resolve } from 'node:path';
2+
import type { StorybookConfig } from '@storybook/react-vite';
3+
4+
const config: StorybookConfig = {
5+
stories: [
6+
resolve('..', process.cwd(), 'src/**/*.mdx'),
7+
resolve('..', process.cwd(), 'src/**/*.stories.@(js|jsx|mjs|ts|tsx)'),
8+
],
9+
addons: [
10+
'@storybook/addon-a11y',
11+
'@storybook/addon-links',
12+
'@storybook/addon-essentials',
13+
'@storybook/addon-interactions',
14+
],
15+
framework: {
16+
name: '@storybook/react-vite',
17+
options: {},
18+
},
19+
};
20+
21+
export default config;

0 commit comments

Comments
 (0)