Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link check pre-commit hook doesn't allow user-defined configuration #78

Open
2 tasks
tspearconquest opened this issue Aug 7, 2022 · 1 comment · May be fixed by #91
Open
2 tasks

Markdown link check pre-commit hook doesn't allow user-defined configuration #78

tspearconquest opened this issue Aug 7, 2022 · 1 comment · May be fixed by #91
Labels
bug Something isn't working

Comments

@tspearconquest
Copy link

Describe the bug
Unable to provide my own configuration to markdown-link-check via pre-commit

To Reproduce

Expected behavior
I added the markdown-link-check hook to my .pre-commit-config.yaml, and ran pre-commit run -a but found that private links I'm trying to check give a 503. For my case, I am trying to check markdown in a private Gitlab repo. I found I can add a cookie header to the config in order to grant the tool access to check these links if I run markdown-link-check -c config.json README.md but if try to do it by adding -c config.json to the args as below in .pre-commit-config.yaml, then markdown-link-check fails to run properly and throws an error about the configuration:

  - id: markdown-link-check
    args:
    - -c config.json

So I did some checking and I found the script creates its own temp config and provides the -c flag itself to markdown-link-check, which seems to conflict with my -c flag in the args.

Nice to have

  • Terminal output
  • Screenshots

Additional context
Add any other context about the problem here.

@tspearconquest tspearconquest added the bug Something isn't working label Aug 7, 2022
@havimaki-agilebits
Copy link

I have also run into this issue where I need to pass in a configuration file in order to set Authorization headers. Would love to have this updated to reflect markdown-link-check's inherent functionality!

@JeanMGirard JeanMGirard linked a pull request Mar 12, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants