Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.2 Set the rebase option to false by default. #188

Open
jdp999 opened this issue Feb 27, 2015 · 5 comments
Open

v0.12.2 Set the rebase option to false by default. #188

jdp999 opened this issue Feb 27, 2015 · 5 comments

Comments

@jdp999
Copy link

jdp999 commented Feb 27, 2015

Doesn't seem to set the option to false by default.

Didn't have this option set to anything before, and seemed to work fine for all my url's. Did a diff on versions of my minified file and on 2/19/2015 file has url exactly as in my source file. Subsequent versions all have modified url.

Switched my grunt file to explicitly set this option false, and my relative url's remained unchanged.
Removed this option and url's get changed.
Set rebase: true, url's get changed.

Seems like default setting is set as true, but was previously set as false?

@sindresorhus
Copy link
Member

7710001

// @XhmikosR

@XhmikosR XhmikosR changed the title v0.12.2   Set the rebase option to false by default. v0.12.2 Set the rebase option to false by default. Feb 27, 2015
@XhmikosR
Copy link
Member

I (obviously) don't see the same issue. Please share your config.

@sattes-faction
Copy link

I'm having the same issue - I have to set rebase: false in order to get the same behaviour as in pre-v0.12.2 versions:

    cssmin: {
      options: {
        rebase: false
      },
      dist: {
        expand: true,
        cwd: 'dist/themes/',
        src: ['**/*.css'],
        dest: 'dist/themes/',
        ext: '.min.css'
      }
    }

@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2015

PR welcome; I still don't see the issue here.

@tony99nyr
Copy link

I was having continued issues with font-awesome in 0.12.2 but resolved them by updating the less @fa-font-path variable. Another option would be to use a grunt-contrib-copy task to copy the font-awesome files from bower_components into the expected directory of ../fonts.

@import "../bower_components/font-awesome/less/font-awesome.less";
@fa-font-path: "../bower_components/font-awesome/fonts";

@Kimone hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants