-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to embed code to sourcemaps #132
Comments
I completely agree, and have this on my to-do list already. Actually, @mzgoddard and I spent awhile thinking about what we thought are a complete set of source map options for the grunt-contrib suite; you can view what we came up with here. If you feel like making a PR that adheres to those options it'd definitely be merged. Otherwise this should be done in a few weeks. |
@jmeas / @mzgoddard |
@jmeas is this going to be a module? i.e |
@vladikoff, yeah, as I've been thinking about this the past few days I thought it would make sense to pull out the shared bits in a module. But I have none of the details of what that module would look like worked out. @mzgoddard, we should meet again to discuss that possibility – and, of course, anyone else can join if you're interested. |
@jmeas, yup. I've been thinking about it too. I think it'd likely hold any work to normalize source map output by dependent libraries, such as embedding source content if the dependent library doesn't have an option to do that itself. |
+1 |
@jmeas, I think you'll probably need to include an option for specifying the root URL to the original source files if one is making use of the |
@juriejan, the library will generate the path from the map to the source files, leaving it up to the developer to make sure that those source files are accessible by the web server. The workflow for making this work is:
This gives us that functionality you're describing without introducing a new option. We're thinking most users won't care about using the |
@jmeas, I see what you mean, but I still think there might be times that the serving of source and map files won't be that straight forward. What if for some reason files are compiled and source maps are generated before the files are in the location where they are to be served from? I won't mind if you carry on without an extra option since I can't see myself using the I agree that the |
Using embed will handle this case, and as your second paragraph suggests I imagine most people will want to use embed. The difficulties with using |
Sounds good. I can't see myself using |
@jmeas Thank you for working on this. It's awesome to think "man, this would be a great idea..." only to find out it's already in progress. I'm looking forward to this. |
It would be great to add option to embed Coffee code to source map, to not deploy original file to server
The text was updated successfully, but these errors were encountered: