Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e style tests for error conditions in the LRS implementation #7704

Open
easwars opened this issue Oct 7, 2024 · 1 comment
Open

Add e2e style tests for error conditions in the LRS implementation #7704

easwars opened this issue Oct 7, 2024 · 1 comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Status: Help Wanted Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Oct 7, 2024

Existing LRS tests are being moved to xdsclient/tests package and are being made e2e style as part of this PR: #7694

We could add one more test to the above file to verify backoff behavior when the LRS stream implementation receives error from the management server.

Our load reporting API on the xDS client does not report errors returned by the server to the caller. So, the only thing we need to check in this test is to ensure that appropriate backoff happens when stream receives errors, and that backoff is reset when a message is received from the server.

We already have tests for these conditions for the ADS stream. See: https://github.com/grpc/grpc-go/blob/master/xds/internal/xdsclient/tests/ads_stream_backoff_test.go

@easwars easwars added Type: Bug Type: Testing Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Status: Help Wanted and removed Type: Bug labels Oct 7, 2024
@RyanBlaney
Copy link

I started working on building the LRS tests. I already successfully implemented a TestLRS_BackoffAfterStreamFailure and am almost finished with the TestLRS_RetriesAfterBrokenStream. I will create a PR when I'm finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Status: Help Wanted Type: Testing
Projects
None yet
Development

No branches or pull requests

2 participants