Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptors for Python, Node and other languages #11

Open
Malayks opened this issue Jan 12, 2017 · 4 comments
Open

Interceptors for Python, Node and other languages #11

Malayks opened this issue Jan 12, 2017 · 4 comments

Comments

@Malayks
Copy link

Malayks commented Jan 12, 2017

Hello, I have been extensively using the GO-gRPC interceptor to trace few microservices written in go and using gRPC but I have a need to create a py and node service and was wondering if we have any interceptors for python and Javascript so that my polyglot environment is fully traced.

If not I would like to know how can I write my own. Any reference or documentation which can help me write the interceptors for py and js similar to the ones we have fro go and java

@bhs
Copy link
Contributor

bhs commented Jan 12, 2017

@Malayks we would very much value the contributions. Last time I checked, the GRPC-python API did not support interceptors natively, and that was the blocker there. I did not check Javascript.

Could you take a look at the GRPC APIs and report back here? I can apply some gentle pressure to the GRPC-team if the APIs are not sufficient to do the actual interception... they really should be! Thanks.

@Malayks
Copy link
Author

Malayks commented Jan 13, 2017

@bensigelman I took a quick look and could not find native support for interceptors in Node GRPC APIs, did not investigate Python as Node is a priority for me.

@bhs
Copy link
Contributor

bhs commented Jan 17, 2017

@Malayks I added something to the tail of grpc/grpc#8767 (comment) ... feel free to weigh in if you feel like it :)

@Malayks
Copy link
Author

Malayks commented Feb 3, 2017

Thanks @bensigelman. Looks like for the time being, writing a wrapper is the only option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants